Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ducky One 2 SF touch-up #17672

Merged
merged 4 commits into from
Jul 13, 2022
Merged

Ducky One 2 SF touch-up #17672

merged 4 commits into from
Jul 13, 2022

Conversation

noroadsleft
Copy link
Member

Description

  • corrects a JSON syntax error in info.json
  • fix key sizes in QMK Configurator
    ducky_one2sf_1967st_default
  • reworks the readme files

cc @f7urry (de-facto keyboard maintainer)

Types of Changes

  • Enhancement/optimization
  • Keyboard (addition or update)

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • I have read the CONTRIBUTING document.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Moves nearly all of the information about this keyboard to the 1967st version's readme, because this readme is exposed in QMK Configurator.

Also updates the readme to align more closely with QMK's keyboard readme template.
Updates the keyboard name and maintainer fields.
@zvecr zvecr merged commit 4ef0c82 into qmk:master Jul 13, 2022
@noroadsleft noroadsleft deleted the rf/ducky_one2sf_1967st branch July 14, 2022 02:57
WonderBeat pushed a commit to post-engineering/qmk_firmware that referenced this pull request Jul 16, 2022
* 'master' of github.com:qmk/qmk_firmware: (179 commits)
  [Keymap] Crkbd/thunderbird2086 (qmk#16973)
  Suavity Ehan Refactor (qmk#17694)
  feat(keebwerk): added VIA support keymap for keebwerk nano slider (qmk#16761)
  FJLabs Solanis Refactor (qmk#17686)
  [Keyboard] add ProjectCain Relic (qmk#15577)
  [Keyboard] eHan Keyboard (qmk#15861)
  Move ins, home and pgup keys to the left (qmk#17690)
  [Keymap] emp keymap for keebio/iris (qmk#16858)
  Ignore kbfirmware exports (qmk#17687)
  [Keyboard] Added TutelPad keyboard (qmk#16975)
  [Keyboard] Add Chocofly v1 (qmk#17289)
  KB16-01: correct QMK Configurator key sequence (qmk#17670)
  Nayeon Community Layout support (qmk#17665)
  [Keyboard] Fix Tractyl Manuform 4x6 json (qmk#17681)
  [Keyboard] Readme file correction (qmk#17674)
  KPrepublic BM80v2 ISO Refactor (qmk#17660)
  [Keyboard] MechWild BB Steno (qmk#17163)
  [Keyboard] Modelm101 teensy2 (qmk#16805)
  Ducky One 2 SF touch-up (qmk#17672)
  Gentoo & Gentoo Hotswap: correct Configurator key sequence errors (qmk#17668)
  ...
smocky pushed a commit to smocky/qmk_firmware that referenced this pull request Jul 22, 2022
* info.json: correct JSON syntax error

* info.json: correct key sizes

* update readme files

Moves nearly all of the information about this keyboard to the 1967st version's readme, because this readme is exposed in QMK Configurator.

Also updates the readme to align more closely with QMK's keyboard readme template.

* info.json: update metadata

Updates the keyboard name and maintainer fields.
schattenbrot pushed a commit to schattenbrot/qmk_firmware that referenced this pull request Aug 2, 2022
* info.json: correct JSON syntax error

* info.json: correct key sizes

* update readme files

Moves nearly all of the information about this keyboard to the 1967st version's readme, because this readme is exposed in QMK Configurator.

Also updates the readme to align more closely with QMK's keyboard readme template.

* info.json: update metadata

Updates the keyboard name and maintainer fields.
imhoffman pushed a commit to imhoffman/qmk_firmware that referenced this pull request Aug 20, 2022
* info.json: correct JSON syntax error

* info.json: correct key sizes

* update readme files

Moves nearly all of the information about this keyboard to the 1967st version's readme, because this readme is exposed in QMK Configurator.

Also updates the readme to align more closely with QMK's keyboard readme template.

* info.json: update metadata

Updates the keyboard name and maintainer fields.
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
* info.json: correct JSON syntax error

* info.json: correct key sizes

* update readme files

Moves nearly all of the information about this keyboard to the 1967st version's readme, because this readme is exposed in QMK Configurator.

Also updates the readme to align more closely with QMK's keyboard readme template.

* info.json: update metadata

Updates the keyboard name and maintainer fields.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants