Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quark revision - rotary encoder and 7u support #17664

Merged
merged 12 commits into from
Sep 16, 2022

Conversation

npspears
Copy link
Contributor

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@npspears
Copy link
Contributor Author

Please merge. It's been 5 weeks. Thank you :)

@drashna drashna requested a review from a team August 23, 2022 02:21
@npspears
Copy link
Contributor Author

added back in the layouts under rules.mk

@drashna drashna requested a review from a team August 31, 2022 01:32
Copy link
Contributor

@keyboard-magpie keyboard-magpie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@github-actions github-actions bot added the via Adds via keymap and/or updates keyboard for via support label Sep 16, 2022
@npspears
Copy link
Contributor Author

This should be updated to use https://docs.qmk.fm/#/feature_encoders?id=encoder-map

Done. Please let me know if I didn't do it right

Co-authored-by: Joel Challis <git@zvecr.com>
@keyboard-magpie keyboard-magpie merged commit 799046f into qmk:master Sep 16, 2022
ohlin added a commit to ohlin/qmk_firmware that referenced this pull request Sep 19, 2022
* master: (28 commits)
  [Docs] Extract 'Layer Change Code' and EEPROM (qmk#18174)
  Add home row modifiers to dshields keymaps. (qmk#18376)
  Reduce charue/sunsetter_r2 firmware size (qmk#18378)
  Add encoder map to BDN9 VIA keymap (qmk#18388)
  FIx ARRAYSIZE def and Murphpad string array (qmk#18392)
  Fixup axon40 lint. (qmk#18409)
  [keyboard] kbdfans/kbd75rgb info.json fix (qmk#18391)
  Bump anothrNick/github-tag-action from 1.45.0 to 1.46.0 (qmk#18386)
  Quark revision - rotary encoder and 7u support (qmk#17664)
  Initial support for Tetromino added (qmk#18341)
  Add ability to remove temporary files during multibuild. (qmk#18381)
  Fix handwired/swiftrax/bumblebee layout macro (qmk#18377)
  [Keyboard] Add pi40 (qmk#18207)
  [Keyboard] Removal of deprecated defines in IDOBAO keyboards (qmk#18358)
  Fix problem that Chidori is not recognized by host computer. (qmk#17882)
  [Keyboard] Add a new keyboard 'plum47' (qmk#18359)
  [Docs] RESET -> QK_BOOT (qmk#18365)
  Remove `RESET` keycodes from fjlabs keyboards (qmk#18364)
  [Keyboard] Add Vector PCB (qmk#17380)
  [Keyboard] Add Calice (qmk#17929)
  ...
tacahiroy pushed a commit to tacahiroy/qmk_firmware that referenced this pull request Oct 2, 2022
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants