Fix docs regarding USB_SUSPEND_WAKEUP_DELAY
#17501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Things left to consider: Should we remove all keyboard configurations that already set it to 200? Or should we leave it up to the respective maintainers? |
|
If anything, the documentation should be changed here, not the default. Specifically, when this was introduced, the default was set to 200ms by default and it caused a lot of issues. So it was revert to 0ms (disabled). However, the document didn't get updated to reflect the change. |
ThreeFx
force-pushed
the
fix-usb-suspend-wakeup-delay
branch
from
999b4c4 to
83fd6d9
Compare
|
Makes sense, in this case I've fixed the documentation to reflect that change, with a little note added that tweaking |
ThreeFx
changed the title
USB_SUSPEND_WAKEUP_DELAY to 200ms by defaultUSB_SUSPEND_WAKEUP_DELAY
ThreeFx
force-pushed
the
fix-usb-suspend-wakeup-delay
branch
from
83fd6d9 to
73953f5
Compare
drashna
reviewed
Jul 4, 2022
Documents the change made in qmk#12081
ThreeFx
force-pushed
the
fix-usb-suspend-wakeup-delay
branch
from
73953f5 to
c02ae09
Compare
drashna
approved these changes
Jul 16, 2022
zvecr
approved these changes
Jul 20, 2022
nolanseaton
pushed a commit
to nolanseaton/qmk_firmware
that referenced
this pull request
Jan 23, 2023
Documents the change made in qmk#12081
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This matches the value found in the documentation.
Types of Changes
Issues Fixed or Closed by This PR
Checklist