Support for Raw HID on Linux/OSX and chrome.hid #1669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's important that hosts can identify the Raw HID interface (HID device) separate from the others, like keyboard, mouse, etc. On Windows, it has been done with "usage" and "usage page" IDs, but this isn't possible on other platforms. Switching to using the HID interface number, and forcing it constant regardless of other compile flags, gives a hard reference to that interface for all platforms.
The change is just a reordering of the interface number assignments so the Raw HID is always second (if enabled)... Seems fine for me on Windows.