Add LAYOUT_alice support for Nasu #15513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yep no problems with me!On 18 Dec 2021 10:34 pm, stanrc85 ***@***.***> wrote:
Small addition to Nasu PCB to support full backspace layout/keymaps as well.
@yiancar Let me know if this is alright with you, thanks.
Description
Types of Changes
Core Bugfix New feature Enhancement/optimization Keyboard (addition or update) Keymap/layout/userspace (addition or update) Documentation
Issues Fixed or Closed by This PR
Checklist
My code follows the code style of this project: C, Python I have read the PR Checklist document and have made the appropriate changes. My change requires a change to the documentation. I have updated the documentation accordingly. I have read the CONTRIBUTING document. I have added tests to cover my changes. I have tested the changes and verified that they work and don't break anything (as well as I can manage).
You can view, comment on, or merge this pull request online at:
#15513
Commit Summary
8fad8ac Add LAYOUT_alice support
File Changes (2 files)
M
keyboards/nasu/nasu.h
(14)
M
keyboards/nasu/rules.mk
(2)
Patch Links:
https://github.com/qmk/qmk_firmware/pull/15513.patchhttps://github.com/qmk/qmk_firmware/pull/15513.diff
—Reply to this email directly, view it on GitHub, or unsubscribe.Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
drashna
approved these changes
Dec 19, 2021
fauxpark
approved these changes
Dec 20, 2021
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small addition to Nasu PCB to support full backspace layout/keymaps as well.
@yiancar Let me know if this is alright with you, thanks.
Description
Types of Changes
Issues Fixed or Closed by This PR
Checklist