Oneshot mods timeout #1405
Merged
Oneshot mods timeout #1405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure why travis failed. It seems some keymaps failed for unrelated reasons, any suggestions? |
|
@cquiroz, there were other unreleated issues in the build. Everything here is fine, and Travis is green now. These changes look good to me! |
|
Yes I noted and rebased onto master to get the build fixed |
|
Cool! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While trying to make a tool to display the one mods I noted that
get_oneshot_mods()doesn't get cleared after a oneshot mode gets used.Gitter suggested a fix similar to #1010 so here it is. This solves my problem at least
I also removed a noisy debug statement that's activated on ACTION DEBUG