Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Keyboard] Update Rosa vendorId to something unique for VIA #12918

Merged
merged 1 commit into from
May 16, 2021
Merged

[Keyboard] Update Rosa vendorId to something unique for VIA #12918

merged 1 commit into from
May 16, 2021

Conversation

illvsixn
Copy link

@illvsixn illvsixn commented May 16, 2021 •
edited
Loading

Description

The originally chosen vendorId overlapped with that of one other board. Changed it slightly so Rosa can be appropriately added to VIA ahead of the private buy.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • Fixed overlapping vendorId

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna requested a review from a team May 16, 2021 22:37
@drashna drashna added the via Adds via keymap and/or updates keyboard for via support label May 16, 2021
@drashna
Copy link
Member

drashna commented May 16, 2021

Thanks!

@drashna drashna merged commit 1d3f775 into qmk:master May 16, 2021
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Jul 11, 2021
@illvsixn @HokieGeek
[Keyboard] Update Rosa vendorId to something unique for VIA (qmk#12918)
3c81bce
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
@illvsixn @nhongooi
[Keyboard] Update Rosa vendorId to something unique for VIA (qmk#12918)
18f6eaf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@illvsixn @drashna @fauxpark