Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to exclude keyboards from travis builds #11178

Merged
merged 8 commits into from
Dec 18, 2020
Merged

Conversation

skullydazed
Copy link
Member

Description

To reduce build times and make more travis builds pass we want to start excluding keyboards from the build.

Types of Changes

  • Core
  • Enhancement/optimization
  • Keyboard (addition or update)

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • I have read the CONTRIBUTING document.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@skullydazed skullydazed requested a review from a team December 10, 2020 18:19
@github-actions github-actions bot added the core label Dec 10, 2020
@skullydazed skullydazed added the CI label Dec 10, 2020
util/travis_build.sh Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the CI label Dec 10, 2020
@skullydazed skullydazed requested a review from a team December 10, 2020 20:26
util/list_keyboards.sh Outdated Show resolved Hide resolved
@tzarc
Copy link
Member

tzarc commented Dec 11, 2020

Should we just do keyboards/handwired/.noci by default?

@skullydazed
Copy link
Member Author

Should we just do keyboards/handwired/.noci by default?

The proposed initial list I put together as a starting point has the entirety of handwired in it.

@skullydazed skullydazed requested a review from a team December 15, 2020 01:12
@skullydazed skullydazed merged commit 03cbee8 into master Dec 18, 2020
@skullydazed skullydazed deleted the ci_exclude branch December 18, 2020 20:17
xgnxs pushed a commit to xgnxs/qmk_firmware that referenced this pull request Jan 9, 2021
* add the ability to exclude keyboards from travis builds

* add filtering to make all:

* only skip keyboards during make all:

* working implementation

* forego a CI_KEYBOARDS variable

* optimize the startup by only listing keyboards once

* add sort -u to all list_keyboard invocations

* move the if else if tree back to 1 level
drashna pushed a commit to zsa/qmk_firmware that referenced this pull request Jan 13, 2021
* add the ability to exclude keyboards from travis builds

* add filtering to make all:

* only skip keyboards during make all:

* working implementation

* forego a CI_KEYBOARDS variable

* optimize the startup by only listing keyboards once

* add sort -u to all list_keyboard invocations

* move the if else if tree back to 1 level
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
* add the ability to exclude keyboards from travis builds

* add filtering to make all:

* only skip keyboards during make all:

* working implementation

* forego a CI_KEYBOARDS variable

* optimize the startup by only listing keyboards once

* add sort -u to all list_keyboard invocations

* move the if else if tree back to 1 level
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants