Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Valor default underglow #11093

Merged
merged 2 commits into from
Dec 1, 2020
Merged

Fix Valor default underglow #11093

merged 2 commits into from
Dec 1, 2020

Conversation

Xelus22
Copy link
Contributor

@Xelus22 Xelus22 commented Dec 1, 2020

Description

Turn the default rgb underglow on as it should be.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • Turn on RGB underglow by default

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@Xelus22 Xelus22 changed the title Fix Valor default backlight Fix Valor default underglo Dec 1, 2020
@Xelus22 Xelus22 changed the title Fix Valor default underglo Fix Valor default underglow Dec 1, 2020
@zvecr zvecr requested a review from a team December 1, 2020 15:05
@fauxpark fauxpark merged commit 3aae530 into qmk:master Dec 1, 2020
xgnxs pushed a commit to xgnxs/qmk_firmware that referenced this pull request Jan 9, 2021
@Xelus22 @xgnxs
Fix Valor default underglow (qmk#11093)
090772d
@Xelus22 Xelus22 deleted the valor_fix branch March 24, 2021 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Xelus22 @fauxpark @zvecr