Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo causing redefined error in keymap_french_osx #10962

Merged
merged 1 commit into from
Nov 16, 2020
Merged

Fix typo causing redefined error in keymap_french_osx #10962

merged 1 commit into from
Nov 16, 2020

Conversation

gbotin
Copy link
Contributor

@gbotin gbotin commented Nov 16, 2020

Description

I encountered an error while compiling my french osx based keymap.
I noticed FR_LSAQ was defined twice and FR_RSAQ was missing, probably a miss copy/paste on #8700.

So... here is my one char contribution :)

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label Nov 16, 2020
@zvecr zvecr requested a review from fauxpark November 16, 2020 22:13
@zvecr zvecr requested a review from a team November 16, 2020 22:14
@fauxpark
Copy link
Member

Thanks! (and oops)

@fauxpark fauxpark merged commit 2ffac90 into qmk:master Nov 16, 2020
drashna pushed a commit to zsa/qmk_firmware that referenced this pull request Nov 24, 2020
@gbotin @drashna
Fix typo causing redefined error in keymap_french_osx (qmk#10962)
65e1a20 
Co-authored-by: gbotin <geoffrey.botin@gmail.com>
xgnxs pushed a commit to xgnxs/qmk_firmware that referenced this pull request Jan 9, 2021
@gbotin @xgnxs
Fix typo causing redefined error in keymap_french_osx (qmk#10962)
bd14523 
Co-authored-by: gbotin <geoffrey.botin@gmail.com>
drashna pushed a commit to zsa/qmk_firmware that referenced this pull request Jan 13, 2021
@gbotin @drashna
Fix typo causing redefined error in keymap_french_osx (qmk#10962)
aa41225 
Co-authored-by: gbotin <geoffrey.botin@gmail.com>
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@gbotin
Fix typo causing redefined error in keymap_french_osx (qmk#10962)
88eb18c 
Co-authored-by: gbotin <geoffrey.botin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gbotin @fauxpark @zvecr