Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add dcompact layout for minivan #10951

Merged
merged 7 commits into from
Nov 24, 2020
Merged

add dcompact layout for minivan #10951

merged 7 commits into from
Nov 24, 2020

Conversation

loksonarius
Copy link
Contributor

@loksonarius loksonarius commented Nov 14, 2020 •
edited
Loading

Description

Implementing my layout for the minivan keyboard.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

N/A

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

drashna
drashna requested changes Nov 17, 2020
View reviewed changes
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

n

keyboards/thevankeyboards/minivan/keymaps/dcompact/config.h Outdated Show resolved Hide resolved
keyboards/thevankeyboards/minivan/keymaps/dcompact/keymap.c Show resolved Hide resolved
keyboards/thevankeyboards/minivan/keymaps/dcompact/keymap.c Outdated Show resolved Hide resolved
keyboards/thevankeyboards/minivan/keymaps/dcompact/rules.mk Outdated Show resolved Hide resolved
@loksonarius loksonarius force-pushed the dcompact/add-minivan-layout branch from d997762 to 2dfed42 Compare November 17, 2020 17:22
@loksonarius
Copy link
Contributor Author

Updated with GPL headers and other suggestions.
Thank you so much for the feedback -- I'll keep the suggestions in mind for future updates 🙏

@zvecr zvecr requested a review from a team November 18, 2020 20:57
@loksonarius
Copy link
Contributor Author

Thanks for the feedback @zvecr, I appreciate it 🙏

@zvecr zvecr requested review from a team and drashna November 23, 2020 20:04
@Erovia Erovia merged commit 3fadfb5 into qmk:master Nov 24, 2020
@loksonarius loksonarius deleted the dcompact/add-minivan-layout branch November 25, 2020 16:06
xgnxs pushed a commit to xgnxs/qmk_firmware that referenced this pull request Jan 9, 2021
@loksonarius @drashna
@zvecr @xgnxs
add dcompact layout for minivan (qmk#10951)
e6cefe9 
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Joel Challis <git@zvecr.com>
Co-authored-by: Dan Herrera <sonarius@shew.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr approved these changes

@fauxpark fauxpark fauxpark approved these changes

@Erovia Erovia Erovia approved these changes

@drashna drashna Awaiting requested review from drashna

Assignees
No one assigned
Labels
keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@loksonarius @drashna @Erovia @fauxpark @zvecr