Update massdrop/alt and arm_atsam/led_matrix to fix #10813 #10818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fauxpark
reviewed
Nov 1, 2020
|
This should likely also be done for the CTRL, but I don't have a keyboard to verify the changes. I've pushed the equivalent CTRL changes to my branch (it is implemented for both the Caps Lock and Scroll Lock options on the CTRL). The CTRL seemed to have this already partially, but not entirely, implemented. |
fauxpark
requested changes
Nov 1, 2020
There was a problem hiding this comment.
@ash0x0 @MatthewRobo @XScorpion2 if one of you could test out the CTRL side of things here?
drashna
approved these changes
Nov 2, 2020
XScorpion2
approved these changes
Nov 2, 2020
ash0x0
approved these changes
Nov 2, 2020
Co-authored-by: Ryan <fauxpark@gmail.com>
fauxpark
approved these changes
Nov 2, 2020
noroadsleft
approved these changes
Nov 9, 2020
|
Thanks! |
ChrissiQ
pushed a commit
to ChrissiQ/qmk_firmware
that referenced
this pull request
Nov 10, 2020
14 tasks
BorisTestov
pushed a commit
to BorisTestov/qmk_firmware
that referenced
this pull request
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes the following three changes:
tmk_core/protocol/arm_atsam/led_matrix.cto only change the appearance of the CapsLock key if the LED_FLAG_INDICATOR flag is set.keyboard/massdrop/alt/config_led.cfile to correctly call out all of the modifier keys on the keyboard (in the same style as on massdrop/ctrl) and to add the additional "INDICATOR" flag to the CapsLock key for use as an indicator. I am not entirely sure if this is the right way to deal with using a key LED as an indicator, but it was the closest to the current implementation.keyboard/massdrop/alt/keymaps/default/keymap.cfile to correctly set the "MODIFIER" and "INDICATOR" flags as enabled when cycling between RGB lighting for All/Keys Only/Underglow Only/None.In general, I tried to make minimal changes while still implementing the fix.
Types of Changes
Issues Fixed or Closed by This PR
Checklist