Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add nfriend's ErgoDox EZ keymap #10545

Merged
merged 1 commit into from
Nov 15, 2020
Merged

Add nfriend's ErgoDox EZ keymap #10545

merged 1 commit into from
Nov 15, 2020

Conversation

nfriend
Copy link
Contributor

@nfriend nfriend commented Oct 5, 2020

Description

Adds nfriend's ErgoDox EZ keymap.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@nfriend nfriend force-pushed the nfriend-ergodox-ez-layout branch from 03b3f06 to 9fbff70 Compare October 5, 2020 03:44
drashna
drashna requested changes Oct 5, 2020
View reviewed changes
keyboards/ergodox_ez/keymaps/nfriend/config.h Show resolved Hide resolved
keyboards/ergodox_ez/keymaps/nfriend/keymap.c Outdated Show resolved Hide resolved
keyboards/ergodox_ez/keymaps/nfriend/keymap.c Outdated Show resolved Hide resolved
keyboards/ergodox_ez/keymaps/nfriend/rules.mk Outdated Show resolved Hide resolved
keyboards/ergodox_ez/keymaps/nfriend/rules.mk Outdated Show resolved Hide resolved
@nfriend nfriend force-pushed the nfriend-ergodox-ez-layout branch from 9fbff70 to 57d315a Compare October 5, 2020 13:29
@nfriend
Copy link
Contributor Author

nfriend commented Oct 5, 2020

@drashna Thanks for all the suggestions, they are much appreciated! 😄

I applied all of your suggestions; please let me know if there are any other changes I need to make.

Back to you 🏓

@nfriend nfriend requested a review from drashna October 5, 2020 13:34
drashna
drashna reviewed Oct 8, 2020
View reviewed changes
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a heads, if you only need to switch the alt/gui/control mods, bootmagic may be a better way to do that.

https://docs.qmk.fm/#/feature_bootmagic?id=keycodes

And even if bootmagic isn't enabled, these keycodes still work.

@drashna drashna requested a review from a team October 8, 2020 00:50
@drashna drashna added the keymap label Oct 8, 2020
@noroadsleft noroadsleft requested a review from drashna November 5, 2020 02:21
@drashna drashna merged commit bb9fbd6 into qmk:master Nov 15, 2020
xgnxs pushed a commit to xgnxs/qmk_firmware that referenced this pull request Jan 9, 2021
@nfriend @xgnxs
[Keymap] Add nfriend's ErgoDox EZ keymap (qmk#10545)
db15dec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noroadsleft noroadsleft noroadsleft approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nfriend @drashna @noroadsleft