Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Add Kiibohd bootloader type to bootloader.mk (#9908)" #10126

Merged
merged 1 commit into from
Aug 21, 2020
Merged

Revert "Add Kiibohd bootloader type to bootloader.mk (#9908)" #10126

merged 1 commit into from
Aug 21, 2020

Conversation

tzarc
Copy link
Member

@tzarc tzarc commented Aug 21, 2020

This reverts commit e2d4cd1.

Description

#9908 was raised as the cause of #10067 -- this reverts it for now so that further investigation can occur.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • 10067

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@noroadsleft noroadsleft merged commit 70ce4ba into qmk:master Aug 21, 2020
@fauxpark fauxpark mentioned this pull request Aug 22, 2020
Merged
14 tasks
nicocesar pushed a commit to nicocesar/qmk_firmware that referenced this pull request Sep 6, 2020
@tzarc @nicocesar
Revert "Add Kiibohd bootloader type to bootloader.mk (qmk#9908)" (qmk…
c0454d0 
…#10126)

This reverts commit e2d4cd1.
@tzarc tzarc deleted the revert-9908-ergodox-infinity-failboot-10067 branch September 10, 2020 02:27
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@tzarc
Revert "Add Kiibohd bootloader type to bootloader.mk (qmk#9908)" (qmk…
00e7411 
…#10126)

This reverts commit 74d20b5.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noroadsleft noroadsleft noroadsleft approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tzarc @drashna @noroadsleft