oneshot timeout would only timeout after an event. #1010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After setting a ONESHOT_TIMEOUT value, the oneshot layer state would not expire without an event being triggered (key pressed). The reason was that in the process_record function we would return priort to execute the process_action function if it detected a NOEVENT cycle. The process_action contained the codes to timeout the oneshot layer state. The codes to clear the oneshot layer state have been move just in front of where we check for the NOEVENT cycle in the process_record function.
The oneshot cancellation code do not depend on the action_tapping_process and since process_record get called via the action_tapping_process logic moved the oneshot cancellation code into the action_exec function just before the action_tapping_process call
|
Great! Thanks :) |
Merged
mattpcaswell
pushed a commit
to mattpcaswell/qmk_firmware
that referenced
this pull request
Jun 7, 2023
* Enable ISO legends on keymap Add a config option to display ISO legends rather than ANSI * Update var to let * Update logic for mutating array to search Add enable and disable ISO mutations Steno and Iso mutations check to make sure they dont override each other * Fire keycodes mutation on toggleIso * Subscribe to setIso mutation to change tab * Added use of lookupKeycode getter to BaseKey Allows the keymap to dynamically update legends based on the ISO toggle * Wrap if branches and use store in clause * Suggested Implementation - moved active state to keycodes model to make it easier to coordinate state changes from events - track state of steno in keycodes - add generateKeycodes helper function to reduce boilerplate - add helper isISO to wrap deep inspection into state model - remove explicit subscription to model changes - only change tab state if we are looking at ANSI/ISO tab * Updated generateKeycodes to use state steno arg passed into func was overriding imported steno * Modify generateKeycodes to use object.key * Reverted to pass args but updated arg names * Update ISO setting label Co-authored-by: Yan-Fa Li <yanfali@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After setting a ONESHOT_TIMEOUT value, the oneshot layer state would
not expire without an event being triggered (key pressed). The reason
was that in the process_record function we would return priort to
execute the process_action function if it detected a NOEVENT cycle. The
process_action contained the codes to timeout the oneshot layer state.
The codes to clear the oneshot layer state have been move just in
front of where we check for the NOEVENT cycle in the process_record
function.