-
-
Notifications
You must be signed in to change notification settings - Fork 40k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tags for info.json #4098
Comments
I'm not sure if this should be generic tags as those are sometimes layout-dependent (i.e. the zeal60 supports either). Or should a keyboard which can have both have both tags? |
@Sebb767 Absolutely. But that's why both should/would be included if the board supports both. Part of the reasoning for this is so we can use a wizard like interface for the QMK Configurator and narrow down boards. Because right now, we have about 200 boards in the main folder. And that doesn't count handwired stuff, nor subfolders like clueboard. |
Also, talked about using something like: {
"tag_categories": {
"stagger": ["ortholinear", "row-staggered", "columar-staggered"],
"layout": ["ansi", "iso", "ortholinear"],
"percentage": ["40p", "50p", "60p", "65p", "66p", "75p", "100p"],
"formfactor": ["tkl", "fullsize", "1800", "40p", "50p", "60p", "65p"]
},
"tag_descriptions": {
"ortholinear": {"description":"Keys laid out in a uniform grid with no stagger"},
"row-staggered": {"description":"Keys laid out with the rows offset from each other"},
"columar-staggered": {"description":"Keys laid out with the columns offset from each other"},
}
} |
Some suggestions:
|
Also, #1584 |
What if the {
"keyboard_name": "ErgoDox EZ",
"url": "ergodox-ez.com",
"maintainer": "erez",
"width": 19.5,
"height": 9.375,
"split": true,
} Some keyboard has incorrect |
Can you link an example or two? That may have been my doing. I set up the |
@noroadsleft Considering I haven't updated my QMK Firmware directory in a while, this is what I can tell at first glance. Wrong width:
Wrong height:
Wrong and width and height:
When I say incorrect in the API that means that is probably incorrect in info.json as well. Regarding keyboards like the ergodone, the ergodox_ez and the ergodox_infinity the width may be already correct if you want the split parts to be more distant (like in KLE) but then all the keys of the right split must move. I may review and check this list when I have more time. |
K, I've checked about half of your list and here's where I'm at: Bugged (Incorrect data in info.json)
Accurate near as I can tell
|
@noroadsleft I can confirm that Plus |
What's the issue, specifically? The Dactyl Manuform variants you've listed all look how I intended them to look. |
@noroadsleft a few hours ago they looked messed up in the configurator. They look good now (I don't know what happened). |
I forgot to consider the timeline. They were broken when you posted that they were, but my pull request linked above was merged before I asked you for the specific issue. I made a pull request specifically to fix the issue (which persists for other boards). I've done a lot of these so I know how the integration works. |
This issue has been automatically marked as stale because it has not had activity in the last 90 days. It will be closed in the next 30 days unless it is tagged properly or other activity occurs. |
|
In reference to #2621, add tags to the info.json file, such as:
And add documentation for it.
Mostly for reference, we do have a section for the info.json file:
https://docs.qmk.fm/#/hardware_keyboard_guidelines?id=infojson-format
The text was updated successfully, but these errors were encountered: