Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The macro interval is double of what it should be #1477

Closed
fredizzimo opened this issue Jul 8, 2017 · 4 comments
Closed

The macro interval is double of what it should be #1477

fredizzimo opened this issue Jul 8, 2017 · 4 comments
Labels
bug

Comments

@fredizzimo
Copy link
Contributor

fredizzimo commented Jul 8, 2017 •
edited
Loading

The macro interval, I(ms) which is supposed to change the stroke interval of the keypresses is applied both for keydown and keyup, which makes it twice as long as it should be. This could be a documentation issue, or it could be a real issue, but either the code or documentation should be fixed.

Another more minor issue is that the delay is also applied to the I(ms) statement itself, so if you start a macro with that, there will be a delay before the first key is sent.

See test_macro.cpp for more information.
fredizzimo added a commit to fredizzimo/qmk_firmware that referenced this issue Jul 8, 2017
@fredizzimo
Reference issue qmk#1477 from the unit tests
05e5fe4
jackhumbert pushed a commit that referenced this issue Jul 9, 2017
@fredizzimo @jackhumbert
Reference issue #1477 from the unit tests
b3af79e
@drashna
Copy link
Member

drashna commented Mar 25, 2018

Macros are depreciated now.
Should this be closed?

@fredizzimo
Copy link
Contributor Author

I'm not sure, the newer SEND_STRING doesn't allow you to change these intervals in the middle so that's still something that the old macros do better. So I would leave this open at least until that is implemented.

@stale
Copy link

stale bot commented Nov 21, 2019

This issue has been automatically marked as resolved because it has not had activity in the last 90 days. It will be closed in the next 30 days unless it is tagged properly or other activity occurs.

@stale stale bot added the solved label Nov 21, 2019
@drashna drashna added the bug label Nov 21, 2019
@stale stale bot removed the solved label Nov 21, 2019
@jackhumbert
Copy link
Member

I think this can be closed - we can have a new issue for implementing intervals in send_string, but my suspision is that people will be using custom keycodes for this sort of thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jackhumbert @drashna @fredizzimo