Use keyboards.qmk.fm to fetch metadata #927
Conversation
There was a problem hiding this comment.
This builds for me locally, but doesn't work at all (results in a completely blank page):
19:44:21.554 Uncaught Keyboard Metadata URL has not been specified constants.js:9
<anonymous> constants.js:9
js app.js:4544
__webpack_require__ app.js:849
fn app.js:151
<anonymous> cjs.js:31
./node_modules/cache-loader/dist/cjs.js?!./node_modules/babel-loader/lib/index.js!./node_modules/cache-loader/dist/cjs.js?!./node_modules/vue-loader/lib/index.js?!./src/components/ControllerTop.vue?vue&type=script&lang=js& app.js:1077
__webpack_require__ app.js:849
fn app.js:151
<anonymous> ControllerTop.vue:1
./src/components/ControllerTop.vue?vue&type=script&lang=js& app.js:2565
__webpack_require__ app.js:849
fn app.js:151
<anonymous> ControllerTop.vue:1
vue app.js:2553
__webpack_require__ app.js:849
fn app.js:151
<anonymous> cjs.js:18
./node_modules/cache-loader/dist/cjs.js?!./node_modules/babel-loader/lib/index.js!./node_modules/cache-loader/dist/cjs.js?!./node_modules/vue-loader/lib/index.js?!./src/components/Main.vue?vue&type=script&lang=js& app.js:1173
__webpack_require__ app.js:849
fn app.js:151
<anonymous> Main.vue:1
./src/components/Main.vue?vue&type=script&lang=js& app.js:2913
__webpack_require__ app.js:849
fn app.js:151
<anonymous> Main.vue:1
vue app.js:2901
__webpack_require__ app.js:849
fn app.js:151
<anonymous> cjs.js:2
./node_modules/cache-loader/dist/cjs.js?!./node_modules/babel-loader/lib/index.js!./node_modules/cache-loader/dist/cjs.js?!./node_modules/vue-loader/lib/index.js?!./src/views/Home.vue?vue&type=script&lang=js& app.js:1328
__webpack_require__ app.js:849
fn app.js:151
<anonymous> Home.vue:1
./src/views/Home.vue?vue&type=script&lang=js& app.js:4724
__webpack_require__ app.js:849
fn app.js:151
<anonymous> Home.vue:1
vue app.js:4712
__webpack_require__ app.js:849
fn app.js:151
<anonymous> index.js:1
js app.js:4437
__webpack_require__ app.js:849
fn app.js:151
<anonymous> main.js:18
js app.js:4413
__webpack_require__ app.js:849
fn app.js:151
1 app.js:4845
__webpack_require__ app.js:849
checkDeferredModules app.js:46
<anonymous> app.js:925
<anonymous> app.js:928
|
Do you have a different .env file you're using? It seems like you don't have |
|
Okay apparently I needed to restart New issue:
|
This is an issue in the generated api data, which I'll have to address in qmk_firmware. I'll get a PR for that done soon. |
This will be fixed by qmk/qmk_firmware#12997. |
Uhhh... so I may be dumb (probably no "may be" about it), but the "readme in parent directory" is still an issue even though that PR was merged. |
|
The data isn't actually regenerated until a keyboard is merged. |
Yep. Definitely no "may be" about it. |
|
The API data should be updated and all feedback has been addressed. Please let me know if there's anything else we need here. |
There was a problem hiding this comment.
Sorry took too long to review this. My hub config broke when I switched laptop. Finally got it working again today. Much faster as @noroadsleft mentioned
Description
Now that we have
keyboards.qmk.fmupdating regularly using github actions we should use that so we can stop generating duplicate metadata in the API. This PR adds support for doing that. This should help to improve the responsiveness of the UI when the API is under load.I don't know if this is the best approach, I just sorta changed things around until I stopped getting errors. Happy to change anything about this PR.