Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Ui test for localstorage #504

Merged
merged 2 commits into from
Sep 26, 2019
Merged

add Ui test for localstorage #504

merged 2 commits into from
Sep 26, 2019

Conversation

zekth
Copy link
Contributor

@zekth zekth commented Sep 24, 2019

Added ui tests for handling the values of the localstorage.

@noroadsleft noroadsleft requested a review from yanfali September 24, 2019 23:08
yanfali
yanfali approved these changes Sep 26, 2019
View reviewed changes
Copy link
Collaborator

@yanfali yanfali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@yanfali yanfali merged commit dc99c83 into qmk:master Sep 26, 2019
@zekth zekth deleted the ui_test_localstorage branch September 26, 2019 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yanfali yanfali yanfali approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zekth @yanfali