Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prettier cmd #481

Merged
merged 4 commits into from
Oct 1, 2019
Merged

Prettier cmd #481

merged 4 commits into from
Oct 1, 2019

Conversation

zekth
Copy link
Contributor

@zekth zekth commented Aug 25, 2019 •
edited
Loading

Following: #480
Here is the addition of raw prettier commands because we are experiencing different behaviours using the vue-cli commands.

Here 2 commits, one pushing the commands, another pushing the modifications using the prettier --write.

Want to run it througth travis to see its behaviour

@zekth
Copy link
Contributor Author

zekth commented Aug 25, 2019

So seems to work properly.
@yanfali your thoughts? could you test on your env?

Also regarding the ci:
https://travis-ci.org/qmk/qmk_configurator/builds/576405648#L453

This triggers me, because it throws errors but the CI is not blocked. Which is wrong no? Or maybe we could just disable those rules.

@zekth zekth changed the title WIP: Prettier cmd Prettier cmd Aug 25, 2019
@yanfali
Copy link
Collaborator

yanfali commented Aug 26, 2019

So seems to work properly.
@yanfali your thoughts? could you test on your env?

Also regarding the ci:
https://travis-ci.org/qmk/qmk_configurator/builds/576405648#L453

This triggers me, because it throws errors but the CI is not blocked. Which is wrong no? Or maybe we could just disable those rules.

Hmm, yeah it's always done that though. I don't know if I consider console, real errors. We can just disable the eslint rule.

@zekth
Copy link
Contributor Author

zekth commented Aug 26, 2019

The console log rule can be deleted IMO

@yanfali
Copy link
Collaborator

yanfali commented Aug 26, 2019

The console log rule can be deleted IMO

I think it's just a matter of setting it off. Right now it's using development/production to decide the rule. If you delete it, it defaults to on

@zekth
Copy link
Contributor Author

zekth commented Aug 26, 2019

The console log rule can be deleted IMO

I think it's just a matter of setting it off. Right now it's using development/production to decide the rule. If you delete it, it defaults to on

was meaning setting it to:

rules: {
        'no-console': 'off',
    },

@yanfali
Copy link
Collaborator

yanfali commented Aug 26, 2019

yeah, do it.

@zekth
Copy link
Contributor Author

zekth commented Aug 26, 2019

Done

@yanfali
Copy link
Collaborator

yanfali commented Sep 30, 2019

@zekth can you rebase this one and let's try and get it merged.

@zekth
Copy link
Contributor Author

zekth commented Oct 1, 2019

@yanfali done

yanfali
yanfali approved these changes Oct 1, 2019
View reviewed changes
Copy link
Collaborator

@yanfali yanfali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

yanfali
yanfali approved these changes Oct 1, 2019
View reviewed changes
Copy link
Collaborator

@yanfali yanfali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yanfali yanfali merged commit a6afb0f into qmk:master Oct 1, 2019
@zekth zekth deleted the prettier_cmd branch October 2, 2019 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yanfali yanfali yanfali approved these changes

Assignees

@yanfali yanfali

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zekth @yanfali @noroadsleft