coverage: default prefix stripping to workspace root #1428

lsegal · 2025-01-15T01:39:15Z

Also: various linter fixes in the qlty-coverage package

qltysh · 2025-01-15T01:41:06Z

The code coverage on the diff in this pull request is 50.0%

Drilldown

Path	File Coverage Δ
qlty-config/src/library.rs	-0.5
qlty-cli/src/commands/coverage/publish.rs	0.8
qlty-coverage/src/print.rs	0.0
qlty-coverage/src/transformer.rs	-10.4
qlty-config/src/workspace.rs	1.3
qlty-coverage/src/publish/planner.rs	-3.2

marschattha · 2025-01-15T10:18:06Z

If I am reading this correctly, won't it sort of undo #1194, i-e the project will need to have a qlty.toml for coverage to work?

Updating tests like #1429 would also prevent the regression.

qlty-cli/src/commands/coverage/publish.rs

qlty-coverage/src/transformer.rs

lsegal · 2025-01-15T17:27:32Z

I think it could make sense to lower the burden to assert_within_git_directory, especially for cloud builds.

coverage: default prefix stripping to workspace root

c187c3e

Also: various linter fixes in the qlty-coverage package

lsegal requested a review from a team January 15, 2025 01:39

lsegal self-assigned this Jan 15, 2025

marschattha reviewed Jan 15, 2025

View reviewed changes

qlty-cli/src/commands/coverage/publish.rs Outdated Show resolved Hide resolved

qlty-coverage/src/transformer.rs Show resolved Hide resolved

3144502

marschattha approved these changes Jan 15, 2025

View reviewed changes

2d44500

lsegal merged commit 470e0ad into main Jan 15, 2025
11 checks passed

lsegal deleted the ls/coverage-fix-run-from-subdir branch January 15, 2025 19:12

Provide feedback