add comment to play_and_record fun

qiuhd · Jul 2, 2023 · fe79654 · fe79654
1 parent cebc0aa
commit fe79654
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/week04_approx_rl/homework_pytorch_debug.ipynb b/week04_approx_rl/homework_pytorch_debug.ipynb
@@ -350,7 +350,7 @@
         "def play_and_record(initial_state, agent, env, exp_replay, n_steps=1):\n",
         "    \"\"\"\n",
         "    Play the game for exactly n_steps, record every (s,a,r,s', done) to replay buffer.\n",
-        "    Whenever game ends, add record with done=True and reset the game.\n",
+        "    Whenever game ends due to termination or truncation, add record with done=terminated and reset the game.\n",
         "    It is guaranteed that env has terminated=False when passed to this function.\n",
         "\n",
         "    PLEASE DO NOT RESET ENV UNLESS IT IS \"DONE\"\n",

diff --git a/week04_approx_rl/homework_pytorch_main.ipynb b/week04_approx_rl/homework_pytorch_main.ipynb
@@ -719,7 +719,7 @@
         "def play_and_record(initial_state, agent, env, exp_replay, n_steps=1):\n",
         "    \"\"\"\n",
         "    Play the game for exactly n_steps, record every (s,a,r,s', done) to replay buffer.\n",
-        "    Whenever game ends, add record with done=True and reset the game.\n",
+        "    Whenever game ends due to termination or truncation, add record with done=terminated and reset the game.\n",
         "    It is guaranteed that env has terminated=False when passed to this function.\n",
         "\n",
         "    PLEASE DO NOT RESET ENV UNLESS IT IS \"DONE\"\n",