Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Batch recommendation API #954

Merged
merged 1 commit into from
Aug 22, 2022
Merged

Batch recommendation API #954

merged 1 commit into from
Aug 22, 2022

Conversation

agourlay
Copy link
Member

This PR adds a batch recommendation API #952

  • built on top of the new batched search API
  • perform points retrieval in a batched fashion as well
  • REST API tested by comparing the result of the batched version with the regular version
  • hardened some tests to actually compare the expected payload across peers in distributed mode
  • fixed a sneaky issue regarding double application of the offset

Once there is a consensus on the implementation, I will refactor the non-batched version so that it uses the batch version with a single request to avoid code duplication.

@agourlay agourlay linked an issue Aug 19, 2022 that may be closed by this pull request
Batch recommendation API #952
Closed
@agourlay agourlay requested a review from generall August 19, 2022 19:32
@generall generall merged commit 03c10fc into master Aug 22, 2022
@agourlay agourlay mentioned this pull request Aug 22, 2022
Merged
@agourlay agourlay deleted the batch-recommendation-api branch September 9, 2022 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@generall generall generall approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Batch recommendation API
2 participants
@agourlay @generall