Peer removal API #894
Merged
Peer removal API #894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
generall
approved these changes
Aug 2, 2022
agourlay
reviewed
Aug 2, 2022
| @@ -323,6 +324,15 @@ impl<C: CollectionContainer> ConsensusState<C> { | |||
| self.persistent.write().insert_peer(peer_id, uri) | |||
| } | |||
|
|
|||
| pub fn remove_peer(&self, peer_id: PeerId) -> Result<(), StorageError> { | |||
| if self.toc.peer_has_shards(peer_id) { | |||
There was a problem hiding this comment.
Should we check if the peer is currently receiving a shard via a transfer?
There was a problem hiding this comment.
Yes, good point. I guess I will add it in the next PR then 😄
Also because of this discussion I noticed that we capture proxy shards in collection snapshot, which is interesting. I will need to recheck the logic here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #874
Design Decisions
Do not shutdown peer if it receives its own removal from consensus. Peer should be later shutdown by script/admin. Otherwise it could interfere with Kubernetes cluster management (it can try to restart the peer).