Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add multipeer deployment test #590

Merged
merged 6 commits into from
May 18, 2022
Merged

Add multipeer deployment test #590

merged 6 commits into from
May 18, 2022

Conversation

e-ivkov
Copy link
Contributor

@e-ivkov e-ivkov commented May 13, 2022 •
edited
Loading

Issue

Closes #582

Fixes

Also contains fixes for snapshot and wal handling as several bugs were discovered during the test.

Test Details

  • Test is written in python as the logic seems too complex for bash script to handle it and be easy to understand
  • Pytest python testing framework is used to run it
  • Current number of peers is set to 5

@e-ivkov e-ivkov requested review from agourlay and generall May 13, 2022 14:54
@e-ivkov e-ivkov self-assigned this May 13, 2022
agourlay
agourlay reviewed May 13, 2022
View reviewed changes
src/main.rs Show resolved Hide resolved
agourlay
agourlay approved these changes May 13, 2022
View reviewed changes
Copy link
Member

@agourlay agourlay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am good to merge it as it is to provide a starting point and iterate over it as we test the distributed deployment.

e-ivkov added 2 commits May 18, 2022 13:47
@e-ivkov
Add multipeer deployment test
e8848c4 
And corresponding fixes for snapshot and wal logic to make test green
@e-ivkov
Add CI for multipeer test
69e798f
generall
generall approved these changes May 18, 2022
View reviewed changes
Copy link
Member

@generall generall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved to not block anybody. But I am preparing some suggestions regarding docker usage in this test

@e-ivkov e-ivkov merged commit 2744093 into master May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@generall generall generall approved these changes

@agourlay agourlay agourlay approved these changes

Assignees

@e-ivkov e-ivkov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Integration test for multipeer deployment
3 participants
@e-ivkov @agourlay @generall