Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In /readyz, wait for Raft commit to be actually applied #5383

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

timvisee
Copy link
Member

@timvisee timvisee commented Nov 6, 2024

Similar to #5350.

Our /readyz will wait for the node to reach the highest Raft commit reported by other peers.

The implementation is wrong. It only waits for that commit to be received, it does not wait for that commit to actually be applied.

All Submissions:

  • Contributions should target the dev branch. Did you create your branch from dev?
  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests?
  2. Have you formatted your code locally using cargo +nightly fmt --all command prior to submission?
  3. Have you checked your code using cargo clippy --all --all-features command?

Copy link
Contributor

@ffuugoo ffuugoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! 👌

@timvisee timvisee merged commit f722572 into dev Nov 6, 2024
17 checks passed
@timvisee timvisee deleted the readyz-wait-for-applied-index branch November 6, 2024 15:08
@timvisee timvisee mentioned this pull request Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants