Update collection config, when applying Raft snapshot #5367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g is incompatible
Recreate optimizers only when required, warn about WAL config update
Compare configs in a less stupid way 🙄
timvisee
reviewed
Nov 5, 2024
timvisee
approved these changes
Nov 5, 2024
generall
approved these changes
Nov 5, 2024
ffuugoo
commented
Nov 6, 2024
Comment on lines
+134
to
+152
| let this_sparse_vectors: HashSet<_> = if let Some(sparse_vectors) = &self.sparse_vectors { | ||
| sparse_vectors.keys().collect() | ||
| } else { | ||
| HashSet::new() | ||
| }; | ||
|
|
||
| let other_sparse_vectors: HashSet<_> = if let Some(sparse_vectors) = sparse_vectors { | ||
| sparse_vectors.keys().collect() | ||
| } else { | ||
| HashSet::new() | ||
| }; | ||
|
|
||
| if this_sparse_vectors != other_sparse_vectors { | ||
| return Err(CollectionError::bad_input(format!( | ||
| "sparse vectors are incompatible: \ | ||
| origin sparse vectors: {this_sparse_vectors:?}, \ | ||
| while other sparse vectors: {other_sparse_vectors:?}", | ||
| ))); | ||
| } |
There was a problem hiding this comment.
Ooops. Missed sparse vectors check. Thanks! 😬
timvisee
pushed a commit
that referenced
this pull request
Nov 8, 2024
Co-authored-by: generall <andrey@vasnetsov.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when applying Raft snapshot, we only update collection optimizer config from the snapshot.
This PR extends this, so that:
Additionally, I've fixed a (potential? I've not yet tested this yet, but I'm 98% sure it's real) deadlock.
All Submissions:
devbranch. Did you create your branch fromdev?New Feature Submissions:
cargo +nightly fmt --allcommand prior to submission?cargo clippy --all --all-featurescommand?Changes to Core Features: