Fixups for VistedPool #5365
Merged
Fixups for VistedPool #5365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What about having a unit test for this case? edit: Andrey pointed at the test later 👍 |
|
There were a test in python client, which cough that. It would be better to have unit test of course. |
generall
reviewed
Nov 5, 2024
| @@ -142,7 +149,7 @@ mod tests { | |||
| assert!(visited_list.check_and_update_visited(0)); | |||
| assert!(visited_list.check(0)); | |||
|
|
|||
| for _ in 0..260 { | |||
| for _ in 0..(u8::MAX as usize * 2 + 10) { | |||
There was a problem hiding this comment.
Oh, I think this is a test already
generall
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR #5336 introduced a in
VisitedListHandlebug which is reproducible after twou8wraparounds.This PR fixes it by reseting
visit_countersevery255iterations, not every256.