Revert experiment: ignore WAL clocks in partial state #5353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
generall
reviewed
Nov 4, 2024
3 tasks
timvisee
force-pushed
the
revert-experiment-ignore-wal-clocks
branch
4 times, most recently
from
efa46a6 to
890f63c
Compare
timvisee
force-pushed
the
revert-experiment-ignore-wal-clocks
branch
from
890f63c to
faed0ed
Compare
Co-authored-by: Andrey Vasnetsov <andrey@vasnetsov.com>
generall
approved these changes
Nov 8, 2024
timvisee
added a commit
that referenced
this pull request
Nov 8, 2024
* Revert "Experiment: in stream records, set cutoff to latest clocks receiver is guaranteed to have (#5375)" This reverts commit e843647. * Revert "Set replica state function does not need to be async anymore (#5379)" This reverts commit fdf08e0. * Revert "Experiment: disable clocks in initializing state, propagate ignore flag (#5372)" This reverts commit 0d98f6f. * Revert "Experiment: also don't write clock tags to WAL in partial state (#5352)" This reverts commit f69ec61. * Revert "Experiment: ignore clock tags when replica is in partial state (#5349)" This reverts commit 1b8a38f. * Keep change to not send updates to replicas in recovery state Co-authored-by: Andrey Vasnetsov <andrey@vasnetsov.com> --------- Co-authored-by: Andrey Vasnetsov <andrey@vasnetsov.com>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts an experiment, consisting of these PRs:
It does keep the change to not send updates to replicas in recovery state (comment).
Some of these changes are significant, and so the plan is to re-implement them a bit later. Reverting them now allows us to do a patch release excluding these changes.