Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document flaky test and add more info in case of failure #535

Merged
merged 1 commit into from
May 2, 2022

Conversation

agourlay
Copy link
Member

@agourlay agourlay commented May 2, 2022

This PR documents and improve the error reporting for #534

I have tried different strategies to reproduce the bug locally but none worked out:

  • repeating the whole test many times
  • increasing the number of attempts
  • repeating the whole test many times with a different StdRng::seed_from_u64

Hopefully we will get more info next time it fails.

@agourlay agourlay requested a review from generall May 2, 2022 12:06
@agourlay agourlay merged commit 794384f into master May 2, 2022
@agourlay agourlay deleted the document-flaky-test branch May 2, 2022 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants