Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix immutable map index mishandling point deletions #5346

Merged
merged 3 commits into from
Nov 1, 2024

Conversation

timvisee
Copy link
Member

@timvisee timvisee commented Nov 1, 2024

Fix a problem where the immutable map index is mishandling point deletions. This was introduced in #5072.

The problem is that while deleting points, the index of a subslice is used. We should use the global index on the container instead.

All Submissions:

  • Contributions should target the dev branch. Did you create your branch from dev?
  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests?
  2. Have you formatted your code locally using cargo +nightly fmt --all command prior to submission?
  3. Have you checked your code using cargo clippy --all --all-features command?

@timvisee
Copy link
Member Author

timvisee commented Nov 1, 2024

Thanks for the test!

@timvisee timvisee merged commit fedebbb into dev Nov 1, 2024
17 checks passed
@timvisee timvisee deleted the fix-immutable-map-index-deleted-positions branch November 1, 2024 18:57
n0x29a pushed a commit that referenced this pull request Nov 4, 2024
* Fix search and delete using subslice index, rather than container intex

* Add sanity checks in debug assertions

* test

---------

Co-authored-by: generall <andrey@vasnetsov.com>
timvisee added a commit that referenced this pull request Nov 8, 2024
* Fix search and delete using subslice index, rather than container intex

* Add sanity checks in debug assertions

* test

---------

Co-authored-by: generall <andrey@vasnetsov.com>
@timvisee timvisee mentioned this pull request Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants