Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefer owned versus referenced usage of PeerId/ShardId, they are Copy #5344

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Prefer owned versus referenced usage of PeerId/ShardId, they are Copy #5344

merged 1 commit into from
Oct 31, 2024

Conversation

timvisee
Copy link
Member

@timvisee timvisee commented Oct 31, 2024 •
edited
Loading

We have mixed usage of owned/referenced PeerId and ShardId types. This attempts to unify it a bit preferring owned usage because it's generally a bit simpler and the types implement Copy.

This PR contains no logic changes.

All Submissions:

  • Contributions should target the dev branch. Did you create your branch from dev?
  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

coszio
coszio approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@coszio coszio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@timvisee timvisee merged commit 83110f1 into dev Oct 31, 2024
17 checks passed
@timvisee timvisee deleted the peer-id-shard-id-copy branch October 31, 2024 14:44
n0x29a pushed a commit that referenced this pull request Nov 4, 2024
@timvisee
Prefer owned versus referenced usage of PeerId/ShardId, they are Copy (…
0ea3020 
…#5344)
timvisee added a commit that referenced this pull request Nov 8, 2024
@timvisee
Prefer owned versus referenced usage of PeerId/ShardId, they are Copy (…
1128ac8 
…#5344)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coszio coszio coszio approved these changes

@generall generall Awaiting requested review from generall

@KShivendu KShivendu Awaiting requested review from KShivendu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timvisee @coszio