Fix shard snapshot operations for s3 #5227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
generall
approved these changes
Oct 14, 2024
timvisee
pushed a commit
that referenced
this pull request
Nov 8, 2024
* Fix shard snapshot operations for s3 * tests/shard-snapshot-api.sh: Improve error reporting * Drop SnapshotStorageManager::get_shard_snapshot_path * Fix s3 test on CI
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turned out that some shard snapshot operations (implemented in #4150) are buggy:
[]).It seems these bugs went unnoticed because the test shard-snapshot-api.sh is also buggy: it enables s3 in the config file, but it doesn't restart qdrant after that. As a result, this integration test doesn't test s3 scenario, but rather tests the local scenario twice.
This PR fixes shard snapshot operations for s3, and fixes the test.