Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When initializing new cluster, propose origin peer to consensus #5141

Merged
merged 8 commits into from
Oct 10, 2024
Merged

When initializing new cluster, propose origin peer to consensus #5141

merged 8 commits into from
Oct 10, 2024

Conversation

ffuugoo
Copy link
Contributor

@ffuugoo ffuugoo commented Sep 25, 2024 •
edited
Loading

Fixes #5138 for new clusters.

All Submissions:

  • Contributions should target the dev branch. Did you create your branch from dev?
  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests?
  2. Have you formatted your code locally using cargo +nightly fmt --all command prior to submission?
  3. Have you checked your code using cargo clippy --all --all-features command?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

timvisee
timvisee reviewed Sep 25, 2024
View reviewed changes
lib/storage/src/content_manager/consensus_manager.rs Show resolved Hide resolved
src/consensus.rs Outdated Show resolved Hide resolved
@timvisee
Copy link
Member

We decided to wait with merging for a bit.

We likely want to merge the other patch first: the patch that fixes this on existing clusters by persisting/sharing the origin peer.

timvisee
timvisee reviewed Sep 27, 2024
View reviewed changes
src/consensus.rs Outdated Show resolved Hide resolved
@ffuugoo ffuugoo force-pushed the consensus-add-origin-peer branch from 1773d26 to 9fa040e Compare October 3, 2024 12:47
@github-actions github-actions bot mentioned this pull request Oct 3, 2024
Open
@ffuugoo ffuugoo force-pushed the consensus-add-origin-peer branch from d65c395 to 5ec1fed Compare October 8, 2024 08:41
@ffuugoo
fixup! Fix collection_creation_passes_consensus test
9c16f79 
Fix another commit index assert 🙄
@ffuugoo ffuugoo requested a review from timvisee October 10, 2024 09:09
timvisee
timvisee approved these changes Oct 10, 2024
View reviewed changes
src/consensus.rs Show resolved Hide resolved
tests/consensus_tests/test_cluster_rejoin.py Show resolved Hide resolved
@ffuugoo @timvisee
Add link to the main issue (#5138) to cluster rejoin tests
d906abb 
Co-authored-by: Tim Visée <tim+github@visee.me>
@github-actions github-actions bot mentioned this pull request Oct 10, 2024
Open
@ffuugoo ffuugoo merged commit c6b6555 into dev Oct 10, 2024
17 checks passed
@ffuugoo ffuugoo deleted the consensus-add-origin-peer branch October 10, 2024 17:30
timvisee added a commit that referenced this pull request Nov 8, 2024
@ffuugoo @timvisee
When initializing new cluster, propose origin peer to consensus (#5141)
83c1dc9 
Co-authored-by: Tim Visée <tim+github@visee.me>
@timvisee timvisee mentioned this pull request Nov 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@generall generall generall approved these changes

@timvisee timvisee timvisee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ffuugoo @timvisee @generall