Add resharding integration tests #5069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
ffuugoo
force-pushed
the
resharding-tests
branch
from
bfb7fd8 to
387ddc9
Compare
ffuugoo
force-pushed
the
resharding-tests
branch
from
fe17f33 to
a8832b9
Compare
Handle `ReshardingScaleDown` replica state
timvisee
approved these changes
Jan 6, 2025
| abort_resharding, | ||
| ]) | ||
|
|
||
| # Finish resharding |
There was a problem hiding this comment.
Since we're also checking we cannot reapply, shall we also assert that we cannot finish resharding a second time?
|
|
||
| peer_api_uris, _peer_dirs, _bootstrap_uri = start_cluster(tmp_path, 3, None, extra_env=env) | ||
| # TODO: Wait for/check... *what*? 🤔 |
There was a problem hiding this comment.
We cannot check this.
Maybe we want to assert the collection is properly deleted, I don't think we can do more. So lets remove the todo.
Comment on lines
+125
to
+126
| @pytest.mark.parametrize("direction, peers", [("up", 3), ("down", 3)]) | ||
| def test_resharding_forward(tmp_path: pathlib.Path, direction: Literal["up", "down"], peers: int): |
There was a problem hiding this comment.
Maybe we can also parameterize the number of shards/replicas (if that isn't too expensive)
timvisee
added a commit
that referenced
this pull request
Jan 8, 2025
Co-authored-by: Tim Visée <tim+github@visee.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR (re)implements resharding integration tests, because existing ones are not applicable anymore, since we moved resharding driver into cluster-manager.
All Submissions:
devbranch. Did you create your branch fromdev?New Feature Submissions:
cargo +nightly fmt --allcommand prior to submission?cargo clippy --all --all-featurescommand?Changes to Core Features: