gRPC API for Distance Matrix #5011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agourlay
commented
Sep 3, 2024
| @@ -274,7 +274,13 @@ fn configure_validation(builder: Builder) -> Builder { | |||
| ("QueryBatchPoints.timeout", "custom(function = \"crate::grpc::validate::validate_u64_range_min_1\")"), | |||
| ("FacetCounts.collection_name", "length(min = 1, max = 255)"), | |||
| ("FacetCounts.key", "length(min = 1)"), | |||
| ("FacetCounts.timeout", "custom(function = \"crate::grpc::validate::validate_u64_range_min_1\")") | |||
| ("FacetCounts.filter", ""), | |||
There was a problem hiding this comment.
added missing validation on FacetCounts.filter
agourlay
commented
Sep 3, 2024
| @@ -13011,16 +13007,18 @@ | |||
| ] | |||
| }, | |||
| "sample": { | |||
| "description": "How many points to select and search within.", | |||
| "description": "How many points to select and search within. Default is 10.", | |||
There was a problem hiding this comment.
I decided to make sample and limit optional for the sake of consistency with other endpoints.
agourlay
force-pushed
the
distance-matrix-gRPC-API
branch
3 times, most recently
from
0e3b3a9 to
afd98a8
Compare
coszio
reviewed
Sep 3, 2024
docs/grpc/docs.md
Outdated
|
|
||
| | Field | Type | Label | Description | | ||
| | ----- | ---- | ----- | ----------- | | ||
| | offsets_row | [uint64](#uint64) | repeated | Row coordinates of the CRS matrix | |
There was a problem hiding this comment.
After some investigation I realized that CRS stands for something else. What we are doing with offsets is more similar to the COO representation
There was a problem hiding this comment.
Good observation 👍
I will get this fixed.
agourlay
force-pushed
the
distance-matrix-gRPC-API
branch
from
f9b6874 to
ece3c13
Compare
coszio
reviewed
Sep 4, 2024
lib/api/src/grpc/proto/points.proto
Outdated
Comment on lines
637
to
638
| repeated uint64 offsets_row = 1; // Row coordinates of the matrix | ||
| repeated uint64 offsets_col = 2; // Column coordinates ids of the matrix |
There was a problem hiding this comment.
How about
Suggested change
| repeated uint64 offsets_row = 1; // Row coordinates of the matrix | |
| repeated uint64 offsets_col = 2; // Column coordinates ids of the matrix | |
| repeated uint64 row_indices = 1; // Row indices of the matrix | |
| repeated uint64 col_indices = 2; // Column indices of the matrix |
And same for REST
coszio
approved these changes
Sep 4, 2024
timvisee
pushed a commit
that referenced
this pull request
Sep 17, 2024
* gRPC API for Distance Matrix * generate API docs * apply correct limit to sample * add JWT tests * pluralitiy * fix COO naming * drops COO as it trips codespell and is redundant * clarify docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
context: https://github.com/qdrant/qdrant/milestone/11
This PR adds gRPC endpoints to the new distance matrix API