Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unecessary Clippy allows #4142

Merged
merged 1 commit into from
Apr 30, 2024
Merged

Remove unecessary Clippy allows #4142

merged 1 commit into from
Apr 30, 2024

Conversation

agourlay
Copy link
Member

Maybe we changed our code or maybe Clippy changed the lints.

In any case we should not keep those escape hatches in place.

@agourlay agourlay requested a review from timvisee April 30, 2024 07:40
timvisee
timvisee approved these changes Apr 30, 2024
View reviewed changes
Copy link
Member

@timvisee timvisee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like there's a bunch more allows that are not needed anymore. But its quite labor intensive to test all of them. 😄

@agourlay
Copy link
Member Author

@timvisee I am doing a partial scan at each Clippy release. We will slowly get there 👍

@timvisee timvisee merged commit 48e74c6 into dev Apr 30, 2024
17 checks passed
@timvisee timvisee deleted the remove-unecessary-clippy-allow branch April 30, 2024 07:57
generall pushed a commit that referenced this pull request May 2, 2024
@agourlay @generall
Remove unecessary Clippy allows (#4142)
4060f36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timvisee timvisee timvisee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@agourlay @timvisee