Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate segment and point level version handling #4057

Merged
merged 3 commits into from
Apr 17, 2024

Conversation

timvisee
Copy link
Member

@timvisee timvisee commented Apr 17, 2024

Supersedes: #4051

Separate version handling for segments and points. Some operations only need to do point level version checks, while others only need segment level checks.

Before this PR, point versions check did fall back to segment version checks if that point did not exist yet.

All Submissions:

  • Contributions should target the dev branch. Did you create your branch from dev?
  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests?
  2. Have you formatted your code locally using cargo +nightly fmt --all command prior to submission?
  3. Have you checked your code using cargo clippy --all --all-features command?

@timvisee timvisee marked this pull request as ready for review April 17, 2024 12:59
@timvisee timvisee requested review from generall and ffuugoo April 17, 2024 12:59
@timvisee timvisee merged commit c3bb009 into dev Apr 17, 2024
17 checks passed
@timvisee timvisee deleted the separate-segment-point-versions branch April 17, 2024 13:40
timvisee added a commit that referenced this pull request Apr 22, 2024
* Separate handling segment and point level versions

* Remove point ID in result from segment level functions

* Move bumping segment version into separate method
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants