-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manhattan distance #3079
Merged
Merged
Manhattan distance #3079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaancfidan
commented
Nov 22, 2023
timvisee
reviewed
Nov 23, 2023
generall
approved these changes
Dec 2, 2023
joein
pushed a commit
that referenced
this pull request
Dec 6, 2023
* implemented Manhattan distance * updated quantization dependency * fixed negative distances and doc consistency * fixed neon implementation * updated quantization dependency * updated quantization dependency * removed redundant copy operation * updated quantization dependency * Change back to upstream quantization dependency --------- Co-authored-by: timvisee <tim@visee.me>
generall
pushed a commit
that referenced
this pull request
Dec 6, 2023
* implemented Manhattan distance * updated quantization dependency * fixed negative distances and doc consistency * fixed neon implementation * updated quantization dependency * updated quantization dependency * removed redundant copy operation * updated quantization dependency * Change back to upstream quantization dependency --------- Co-authored-by: timvisee <tim@visee.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on qdrant/quantization#21.
This pull request adds
Manhattan
(L1, taxicab) as a 4th distance type (related to #3052). I am aware that this is an ambitious pull request as a first contribution, but I need the functionality and I think it has a justified place in the product.The related issue mentions generalized Lp, but I thought it did not make much sense to try to implement AVX/SSE/Neon versions for it.
I have tried to follow the
Euclid
distance implementation as close as I could and I have copied the tests related toEuclid
distance and converted them toManhattan
distance tests. I have also created an OpenAPI integration test for it.I have implemented all AVX, SSE and Neon optimized similarity functions, they are all tested on proper hardware.
This pull request depends on the changes on the matching pull request at qdrant/quantization repo.
Once the branch at qdrant/quantization is merged, its dependency should be switched back to its usual form.
All Submissions:
dev
branch. Did you create your branch fromdev
?New Feature Submissions:
cargo +nightly fmt --all
command prior to submission?cargo clippy --all --all-features
command?Changes to Core Features: