Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove fake metric from benches #2754

Merged
merged 1 commit into from
Oct 2, 2023
Merged

Conversation

IvanPleshkov
Copy link
Contributor

Benches panic on the fake metric. There is a user fix for this panic: #1958. Such a fix is incorrect because a mixture of metrics appears. Currently, the raw scorer constructor doesn't allow to use of custom metric types. That's why I propose to remove Fake Metric from the benches and use Dot instead.

All Submissions:

  • Contributions should target the dev branch. Did you create your branch from dev?
  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests?
  2. Have you formatted your code locally using cargo +nightly fmt --all command prior to submission?
  3. Have you checked your code using cargo clippy --all --all-features command?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@IvanPleshkov IvanPleshkov merged commit 05806c8 into dev Oct 2, 2023
@IvanPleshkov IvanPleshkov deleted the remove-fake-metric-from-benches branch October 2, 2023 11:30
generall pushed a commit that referenced this pull request Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants