Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable with_vector flag in api #50 #267

Merged
merged 2 commits into from
Jan 31, 2022
Merged

enable with_vector flag in api #50 #267

merged 2 commits into from
Jan 31, 2022

Conversation

generall
Copy link
Member

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests?
  2. Have you lint your code locally using cargo fmt command prior to submission?
  3. Have you checked your code using cargo clippy command?

@generall generall assigned generall and unassigned generall Jan 30, 2022
@generall generall requested a review from agourlay January 30, 2022 18:38
@agourlay
Copy link
Member

agourlay commented Jan 31, 2022 •
edited
Loading

The change looks good to me 👍

Is it possible to have a short integration test to make sure everything is wired up properly and to protect ourselves from a regression?

@generall
Copy link
Member Author

there should be a test, definitely. But maybe as a part of migration from the bash script;)

@generall generall merged commit a2f3504 into master Jan 31, 2022
@generall generall deleted the include-vector-into-retrieve branch January 31, 2022 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agourlay agourlay Awaiting requested review from agourlay

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@generall @agourlay