Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Numeric field index refactoring. Required changes for #2666
struct NumericIndex
was converted intoenum NumericIndex
with only one variantMutable
(#2666 intriducesImmutable
variant, I hope in future we will implementMmap
variant too).Mutable
variant contains all fields from the oldstruct NumericIndex
, and has the same load/delete/add methods as the old ones. All filters/estimations are the same but with changed access to old structure fields. Now it was added new methods to access Mutable fields:Also the whole file
numeric_index.rs
was separated into parts withNumericIndex
, mutable state, and tests. It's the same strategy that was applied to Map Index.All Submissions:
dev
branch. Did you create your branch fromdev
?New Feature Submissions:
cargo +nightly fmt --all
command prior to submission?cargo clippy --all --all-features
command?Changes to Core Features: