openapi definitions for shard shashots API #2571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
generall
commented
Sep 2, 2023
generall
commented
- OpenAPI definitions
- OPenAPI tests
- minor consistency changes
ffuugoo
requested changes
Sep 4, 2023
Comment on lines
157
to
165
| response = request_with_validation( | ||
| api='/collections/{collection_name}/shards/{shard_id}/snapshots/recover', | ||
| method="PUT", | ||
| path_params={'shard_id': 0, 'collection_name': "somethingthatdoesnotexist"}, | ||
| body={ | ||
| "location": "file://localhost/whatever.snapshot", | ||
| } | ||
| ) | ||
| assert response.status_code == 404 |
There was a problem hiding this comment.
We decided to not use file:// URLs for shard snapshot recovery, and so explicitly check that locations is either HTTP(S) URL or a plain path. file:// should return error 400.
See:
| content: | ||
| application/json: | ||
| schema: | ||
| $ref: "#/components/schemas/SnapshotRecover" |
There was a problem hiding this comment.
recover_shard_snapshot uses ShardSnapshotRecover, which is a bit different from SnapshotRecover, because we decided not to use file:// URLs for shard snapshot API.
See:
8 tasks
ffuugoo
approved these changes
Sep 4, 2023
generall
added a commit
that referenced
this pull request
Sep 4, 2023
* openapi definitions for shard shashots API * review fixes
75 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.