Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web UI integration #2009

Merged
merged 5 commits into from
Jun 6, 2023
Merged

Web UI integration #2009

merged 5 commits into from
Jun 6, 2023

Conversation

generall
Copy link
Member

@generall generall commented Jun 1, 2023

ToDo:

  • Exception for authentication
  • Option to disable web ui from config
  • ???

@generall generall force-pushed the web-ui-integration branch from 468b34e to 7563e78 Compare June 1, 2023 10:50
Copy link
Member

@timvisee timvisee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple yet effective. Nice work!

@@ -0,0 +1,18 @@
#!/usr/bin/env bash

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may want to add set -e or even set -euo pipefail here?

@timvisee
Copy link
Member

timvisee commented Jun 1, 2023

Option to disable web ui from config

Maybe we could not serve static files if the directory in settings is not present?

@generall generall force-pushed the web-ui-integration branch from b98cfd6 to 63b57a1 Compare June 1, 2023 21:30
@generall generall requested a review from agourlay June 6, 2023 14:07
@generall generall changed the title WIP: Web UI integration Web UI integration Jun 6, 2023
Copy link
Member

@agourlay agourlay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice integration 👍

@generall generall merged commit 967d387 into dev Jun 6, 2023
generall added a commit that referenced this pull request Jun 19, 2023
* wip: integrate UI web interface

* fmt

* Api key exclusion rule + fixes

* upd welcome url

* rollback api key in config
@agourlay agourlay deleted the web-ui-integration branch July 12, 2023 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants