CI: make integration tests 45% faster #1902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timvisee
approved these changes
May 16, 2023
generall
pushed a commit
that referenced
this pull request
May 17, 2023
* use scope="module" where possible * refactor test_snapshot.py to use loop and timeout instead of long waits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the performance of tests by reusing the setup for every test in the same file (where it makes sense). Also refactor to use loop and timeout where a simple
sleepwas usedLocally, the integration test suite duration went from 32.64s to 18.23s, hence the ~45% speedup
All Submissions: