Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add REST interface to update/delete optional named vectors #1836

Merged
merged 4 commits into from
May 5, 2023
Merged

Add REST interface to update/delete optional named vectors #1836

merged 4 commits into from
May 5, 2023

Conversation

timvisee
Copy link
Member

@timvisee timvisee commented May 4, 2023 •
edited
Loading

Depends on #1816. Continuation of #1816. Part of #1045.

This adds the REST interface endpoints for updating and deleting optional named vectors.

Tests will be added in a separate PR.

I did some basic testing for this against the REST interface locally.

Tasks

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests?
  2. Have you lint your code locally using cargo fmt command prior to submission?
  3. Have you checked your code using cargo clippy command?

@timvisee timvisee mentioned this pull request May 4, 2023
Merged
8 tasks
@timvisee timvisee requested review from agourlay and generall May 4, 2023 14:27
This was referenced May 4, 2023
Merged
Merged
@timvisee timvisee force-pushed the optional-named-vectors-api branch from e064992 to 16b5d61 Compare May 5, 2023 06:49
@timvisee timvisee force-pushed the optional-named-vectors-rest branch 3 times, most recently from 083eb8d to 9bf13fc Compare May 5, 2023 13:02
@timvisee timvisee changed the base branch from optional-named-vectors-api to dev May 5, 2023 13:19
@timvisee timvisee force-pushed the optional-named-vectors-rest branch from 9bf13fc to 4b23822 Compare May 5, 2023 13:20
@timvisee timvisee marked this pull request as ready for review May 5, 2023 13:20
@timvisee timvisee changed the title Draft: add REST interface to update/delete optional named vectors Add REST interface to update/delete optional named vectors May 5, 2023
@timvisee timvisee merged commit eb79479 into dev May 5, 2023
@timvisee timvisee mentioned this pull request May 15, 2023
Merged
generall pushed a commit that referenced this pull request May 17, 2023
@timvisee @generall
Add REST interface to update/delete optional named vectors (#1836)
f9b679a 
* Add update/delete REST endpoints

* Add update/delete vector REST endpoints to OpenAPI specification

* Fix update vector with no changes not triggering a validation error

* Update OpenAPI specification for updated request type
@agourlay agourlay deleted the optional-named-vectors-rest branch July 12, 2023 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@generall generall generall approved these changes

@agourlay agourlay Awaiting requested review from agourlay

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timvisee @generall