Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert hnsw m min value validation #1797

Merged
merged 3 commits into from
Apr 27, 2023
Merged

Revert hnsw m min value validation #1797

merged 3 commits into from
Apr 27, 2023

Conversation

IvanPleshkov
Copy link
Contributor

@IvanPleshkov IvanPleshkov commented Apr 27, 2023

HNSW m=0 case is valid and required in API

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests?
  2. Have you lint your code locally using cargo fmt command prior to submission?
  3. Have you checked your code using cargo clippy command?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@IvanPleshkov IvanPleshkov requested a review from generall April 27, 2023 15:32
@generall generall merged commit 531abf5 into dev Apr 27, 2023
generall pushed a commit that referenced this pull request Apr 27, 2023
* revert hnsw m min value

* grpc goo

* update openapi
@agourlay agourlay deleted the revert-m-min-value branch July 12, 2023 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants