Added workflow to link binaries with releases #1767
Conversation
|
Jobs for Ubuntu are running well, but the ones for Mac are taking longer than expected. I will update the status as they progress. Regarding building binaries for Windows, I encountered difficulties installing "clang" and "gcc-multilib" on that platform. Can you share steps you use to build on Windows? |
|
For testing, I created a Release in my forked repo - https://github.com/Shubham8287/qdrant/releases/tag/18. Not sure, how to test here. @agourlay, please let me know if you have any concerns with my approach. I made an effort to optimize the use of https://github.com/taiki-e/upload-rust-binary-action, so I didn't require to separate the build and upload stages, just installing system dependencies as prior step. |
We have windows CI in here https://github.com/qdrant/qdrant/blob/master/.github/workflows/rust.yml#L18 |
This looks helpful, I will give it a try. Thanks! |
|
@generall I tried your advice, and added similar steps as rust.yml workflow but it seems to fail for some Perl dependency - https://github.com/Shubham8287/qdrant/actions/runs/4768237918/jobs/8477332680. I tried to explicitly install Perl and its dependency - https://github.com/Shubham8287/qdrant/actions/runs/4768167880/workflow but still no luck :( |
|
@Shubham8287 If it builds tests, it should also be able to build release binaries. |
|
thanks! trying out. |
|
I updated the code for including windows binary as well, you can refer here to see example Relasen- https://github.com/Shubham8287/qdrant/releases/tag/26 |
| strategy: | ||
| matrix: | ||
| include: | ||
| - target: x86_64-unknown-linux-gnu |
There was a problem hiding this comment.
Would it be possible to also add aarch64-unknown-linux-gnu to the targets?
There was a problem hiding this comment.
Sure, I will try this!
There was a problem hiding this comment.
Hi, I tried it.
I realised we can't use https://github.com/taiki-e/upload-rust-binary-action action for aarch as this GA uses cross aarch container to compile code but we need to install few dependencies beforehand.
I tried to directly use cross by configuring Cross.toml https://github.com/cross-rs/cross/blob/main/docs/cross_toml.md#targettargetpre-build but the build is still not going through- https://github.com/Shubham8287/qdrant/actions/runs/4787382241/workflow#L50, Also I am not able to build it locally with cross, dependencies still messing up after many attempts.
Can you please verify if you can build it locally for aarch as you understand dependencies much better?
There was a problem hiding this comment.
I asked you about aarch64-unknown-linux-gnu because I had trouble doing it in the past as well 😺
I propose to go with the PR as it is and work on aarch64-unknown-linux-gnu when it is needed.
| repo-token: ${{ secrets.GITHUB_TOKEN }} | ||
|
|
||
| - name: Build | ||
| run: cargo build --release --locked |
There was a problem hiding this comment.
Why is it necessary to build the project twice for Windows?
There was a problem hiding this comment.
Only this step is building the project, not the later one. The next step picks the binary build here and uploads them. This is basically a workaround because for windows, taiki-e/upload-rust-binary-action is not building the code no matter what target I use -https://github.com/Shubham8287/qdrant/actions/runs/4783873767/jobs/8504657732. I may check with GA maintainer for the issue later but building it explicitly looks harmless so I adopted it :).
There was a problem hiding this comment.
Alright, so the GA only build the project if the binary is not already present.
I guess we can live with the workaround 👍
|
@Shubham8287 there is a new rust version, could you please rebase to the current dev, so CI will pass? |
|
Also, please move your PR to |
sure! |
Shubham8287
force-pushed
the
shub/added-release-workflow
branch
from
39df175 to
26d02c7
Compare
All Submissions:
New Feature Submissions:
cargo fmtcommand prior to submission?cargo clippycommand?Changes to Core Features:
PR for #1733
/claim #1733