Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REST] alias with_vector <-> with_vectors #1697

Merged
merged 1 commit into from
Apr 11, 2023
Merged

[REST] alias with_vector <-> with_vectors #1697

merged 1 commit into from
Apr 11, 2023

Conversation

coszio
Copy link
Contributor

@coszio coszio commented Apr 11, 2023 •
edited
Loading

Makes alias for with_vector parameter, to enable the plural form (with_vectors) in REST API requests.

Solves #1554

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests?
  2. Have you lint your code locally using cargo fmt command prior to submission?
  3. Have you checked your code using cargo clippy command?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@coszio coszio requested review from agourlay and generall April 11, 2023 14:36
@coszio
Copy link
Contributor Author

coszio commented Apr 11, 2023

@generall this is what was expected, right? or was it the other way around? E.g alias with_vector and refactor codebase for the plural form

@generall
Copy link
Member

yes, but also PointRequest

@coszio
Copy link
Contributor Author

coszio commented Apr 11, 2023 via email •
edited
Loading

@generall generall merged commit 7af32ec into dev Apr 11, 2023
generall pushed a commit that referenced this pull request Apr 11, 2023
@coszio @generall
feat: [http] alias with_vector <-> with_vectors (#1697)
4ac3c6a
@timvisee timvisee mentioned this pull request Apr 12, 2023
Closed
@generall generall mentioned this pull request Apr 19, 2023
Closed
8 tasks
@coszio coszio mentioned this pull request May 16, 2023
Closed
@agourlay agourlay deleted the alias-for-with-vector branch July 12, 2023 15:47
@davidmyriel davidmyriel mentioned this pull request Jul 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@generall generall generall approved these changes

@timvisee timvisee timvisee approved these changes

@agourlay agourlay Awaiting requested review from agourlay

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@coszio @generall @timvisee