-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add vector specific HNSW configuration #1675
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
timvisee
force-pushed
the
multi-vector-hnsw-config2
branch
from
April 6, 2023 16:35
ba97602
to
bbfc4ee
Compare
timvisee
commented
Apr 7, 2023
timvisee
force-pushed
the
multi-vector-hnsw-config2
branch
from
April 7, 2023 08:31
c9f95a0
to
1c06bb0
Compare
timvisee
changed the title
Draft: add vector specific HNSW configuration
Add vector specific HNSW configuration
Apr 7, 2023
17 tasks
generall
approved these changes
Apr 10, 2023
timvisee
force-pushed
the
multi-vector-hnsw-config2
branch
from
April 10, 2023 14:08
beb775e
to
a36b29c
Compare
generall
added a commit
that referenced
this pull request
Apr 11, 2023
* Validate VectorConfig/VectorParams, remove obsolete validation * Add HNSW config diff to vector parameters * Validate params in collection config * Add HNSW config to segment vector data config * Add VectorsConfig params iterator for more elegant conversions * Prefer vector HNSW config over collection config for building HNSW index * Base segment vector param HNSW config on collection config * General improvements * Rewrite HNSW ef_construct extract function to also consider vector configs * Update OpenAPI specification * Add test to check if vector specific HNSW config is persisted * review changes * review changes * Regenerate gRPC docs * Fix test on Windows * Regenerate OpenAPI specification --------- Co-authored-by: Andrey Vasnetsov <andrey@vasnetsov.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for vector specific HNSW configurations. This allows to set different HNSW parameters for different vectors in a multi-vector collection better fine tune performance.
In this example create collection request,
modified_vector
utilizes different HNSW parameters:Tasks
After merge
multi-vector-hnsw-config
)All Submissions:
New Feature Submissions:
cargo fmt
command prior to submission?cargo clippy
command?Changes to Core Features: